Add "config fabric port ..." commands and tests. #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sanmalho-git fyi |
arlakshm
reviewed
Apr 17, 2023
There was a problem hiding this comment.
changes look good. Since this is config command can we add these commands to this document https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md
done. Thank you |
|
Looks good to me as well. |
arlakshm
approved these changes
May 15, 2023
gechiang
added
the
included in chassis for 202205 branch
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
…-net#2730) Added "config fabric port ..." commands and the tests. This change added following config commands and the test for them. config fabric port isolate #portId# config fabric port unisolate #portId# The above two commands can be used to manually isolate and unisolate a fabric link. config fabric port monitor error threshold #crcCells# #rxCells# It sets a fabric link monitoring error threshold config fabric port monitor poll threshold isolation #pollnumber# It sets the number of consecutive polls in which the threshold needs to be detected to isolate a link config fabric port monitor poll threshold recovery #pollnumber# It sets the number of consecutive polls in which no error is detected to unisolate a link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "config fabric port ..." commands and the tests.
This change added following config commands and the test for them.
config fabric port isolate #portId#
config fabric port unisolate #portId#
The above two commands can be used to manually isolate and unisolate a fabric link.
config fabric port monitor error threshold #crcCells# #rxCells#
It sets a fabric link monitoring error threshold
config fabric port monitor poll threshold isolation #pollnumber#
It sets the number of consecutive polls in which the threshold needs to be detected to isolate a link
config fabric port monitor poll threshold recovery #pollnumber#
It sets the number of consecutive polls in which no error is detected to unisolate a link
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)